Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed pointer from bootcamps at developers Learning page (Fixes #13521) #13605

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

panditdhamdhere
Copy link
Contributor

Bug report #13521

Description

In Developers Learning tools and Developer bootcamps section when we open Pointer Learn web3 dev skills with fun interactive tutorials. Earn crypto rewards along the way the link shows 404 deployment not found.

I removed Pointer from the code as it was assigned to me.

issue here

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit b6af481
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66c4e5740c64b30008e74f27
😎 Deploy Preview https://deploy-preview-13605--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🔴 down 4 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@panditdhamdhere
Copy link
Contributor Author

Hi @pettinarip can anyone review this

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @panditdhamdhere 💪

This looks good, but I think we should do the additional cleanup in this PR also. Would you be able to:

  • remove all instances of "page-developers-learning-tools:page-learning-tools-pointer-description" from our intl files? (a search and remove of these will do it)
  • delete the image that we were importing (@/public/images/dev-tools/pointer.png)

Thanks!

@minimalsm minimalsm changed the title Removed pointer from bootcamps at developers Learning page Removed pointer from bootcamps at developers Learning page (Closes #13521) Aug 20, 2024
@minimalsm minimalsm changed the title Removed pointer from bootcamps at developers Learning page (Closes #13521) Removed pointer from bootcamps at developers Learning page (Fixes #13521) Aug 20, 2024
@minimalsm minimalsm linked an issue Aug 20, 2024 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Aug 20, 2024
@panditdhamdhere
Copy link
Contributor Author

Hi @minimalsm Can you please check now and give me feedback? Thank you very much for your suggestions.

@corwintines corwintines self-assigned this Aug 27, 2024
Copy link
Member

@corwintines corwintines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @panditdhamdhere!

@corwintines
Copy link
Member

@all-contributors can you add @panditdhamdhere for code

Copy link
Contributor

@corwintines

I've put up a pull request to add @panditdhamdhere! 🎉

@corwintines corwintines merged commit e57d7a5 into ethereum:dev Aug 27, 2024
6 checks passed
Copy link

gitpoap-bot bot commented Aug 27, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2024 Ethereum.org Contributor:

GitPOAP: 2024 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

This was referenced Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report
3 participants