Shadcn migration - alert #13617
Shadcn migration - alert #13617
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
added
the
needs design approval 🧑🎨
|
@nloureiro tagging you since this needs design review. |
|
@pettinarip this one is for the alerts on top? like this one? |
No, we are not currently using them on prod. You can see them only on Chromatic/Storybook for now. You can see them on the UI tests check or in this link for the Storybook instance for this build. |
|
All looks good on my end. they look even better Just one question: why the |
Great! will approve the UI tests for now then and mark this PR ready for review soon.
Ah hahaha, I don't know, was me doing silly things. Wanted to highlight the code name for each variant. Will remove the |
pettinarip
requested review from
wackerow,
corwintines and
minimalsm
as code owners
| --error-light: var(--error-light); | ||
| --error: var(--red-500); | ||
| --error-light: var(--red-100); | ||
| --error-outline: var(--error); |
There was a problem hiding this comment.
Curious the reason for the -outline token variants?
There was a problem hiding this comment.
Hmm good call, we are not using it, right? I guess the idea was to use this color as the border color. I missed that.
| {...props} | ||
| > | ||
| <MdClose className="h-6 w-6" /> | ||
| <span className="sr-only">Close</span> |
There was a problem hiding this comment.
Nice (ref for anyone else: https://tailwindcss.com/docs/screen-readers)
Description
Adds the new shadcn Alert component.