[ShadCN] refactor(mdComponents): convert components to ShadCN #13620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg canceled.
|
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
pettinarip
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Great job @TylerAPfledderer, I left some comments.
I'm going to check some custom/old colors we use here with Nuno to see if we can replace them with a DS color.
pettinarip
reviewed
Sep 9, 2024
| export const commonHeadingAttributes = (className: string, id?: string) => ({ | ||
| id, | ||
| className: cn( | ||
| "font-bold leading-xs my-8", |
There was a problem hiding this comment.
We will need this as important to avoid being overridden by the global heading sizes
Suggested change
| "font-bold leading-xs my-8", | |
| "font-bold !leading-xs my-8", |
There was a problem hiding this comment.
@pettinarip doing this will override the leading for smaller screen sizes, such as what is used in the h2 for the Docs layout as discussed above
pettinarip
reviewed
Sep 9, 2024
pettinarip
requested changes
Sep 10, 2024
There was a problem hiding this comment.
@TylerAPfledderer good job! everything looks good from my side.
I will block this PR until #13821 is merged since we want to QA this PR with the latest color changes.
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts components in
MdComponentsto ShadCN/Tailwind. Also creates a story set.Closes #13047