Shadcn migration - EnergyConsumptionChart #13633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhburade
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Blockers
|
This was moved recently to https://github.com/ethereum/ethereum-org-website/blob/dev/src/components/ui/buttons/Button.tsx |
pettinarip
requested changes
Aug 15, 2024
There was a problem hiding this comment.
@saurabhburade great job and thanks for the details. Left a couple of comments to reuse a few functions/components that we have built in the transition.
| useBreakpointValue, | ||
| useColorModeValue, | ||
| } from "@chakra-ui/react" | ||
| import { useBreakpointValue, useColorModeValue } from "@chakra-ui/react" |
There was a problem hiding this comment.
Ok about useBreakpointValue. We need to think how we could replace it but not a blocker for this PR though.
cc @TylerAPfledderer maybe something we could do with tv responsive variants? do you have something in mind?
pettinarip
approved these changes
Aug 16, 2024
This was referenced Aug 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate EnergyConsumptionChart to tailwind.