Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update shapeshift feature erc20 import #13684

Merged

Conversation

firebomb1
Copy link
Contributor

@firebomb1 firebomb1 commented Aug 19, 2024

Description

Update the ShapeShift Mobile wallet data to reflect that it now supports importing custom ERC-20 tokens.

Related Issue

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 17b7b83
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66ec14928886640008dec700
😎 Deploy Preview https://deploy-preview-13684--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 40 (🔴 down 8 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@firebomb1
Copy link
Contributor Author

I had forgotten to update the last_update date while I changed the ERC20 Import setting.

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @firebomb1!

@wackerow wackerow merged commit 8dc3691 into ethereum:dev Oct 3, 2024
6 of 7 checks passed
@firebomb1
Copy link
Contributor Author

Thanks @firebomb1!

No problem @wackerow , as I suggested on Discord, the failing test is likely due to an error in the import here:

uses: actions-ecosystem/action-add-comment@v1

Which should rather import actions-ecosystem/action-create-comment. (https://github.com/actions-ecosystem/action-create-comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating ShapeShift Wallet - ERC20 Token Import
2 participants