Shadcn migration - PageHero #13723
Merged
Shadcn migration - PageHero #13723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhburade
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pettinarip
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
@saurabhburade LGTM! thanks
I've pushed a commit with minor style tweaks to align with latest design decisions.
| eventName: button.matomo.eventName, | ||
| }) | ||
| } | ||
| customEventOptions={{ |
tailwind.config.ts
Outdated
| @@ -102,7 +102,10 @@ const config = { | |||
| 800: "var(--orange-800)", | |||
| 900: "var(--orange-900)", | |||
| }, | |||
|
|
|||
| text: { | |||
There was a problem hiding this comment.
Gonna remove these colors because we now default to white in the hero texts.
src/components/PageHero.tsx
Outdated
| ps={{ base: 0, lg: 8 }} | ||
| me={{ base: 0, lg: 4 }} | ||
| <div | ||
| // TODO: container.sm width unavailable |
There was a problem hiding this comment.
Removing comment since we will not have this measure (640px) on the new theme. We can treat it now as a custom size.
There was a problem hiding this comment.
Gotcha!! So every container.sm is considered as a custom size of (640px) .
There was a problem hiding this comment.
Yeah, we don't have that breakpoint on the theme anymore.
pettinarip
approved these changes
Sep 6, 2024
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate PageHero to tailwind.