Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Truffle Suite references as it's being discontinued #13738

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Remove Truffle Suite references as it's being discontinued #13738

merged 1 commit into from
Sep 16, 2024

Conversation

sumitvekariya
Copy link
Contributor

Description

  • Removed truffle mention & references from codebase
  • Tutorials that mentioned truffle, removed the section or mention of the truffle
  • Tutorials that were relying on truffle have been removed entirely

Related Issue

#11262
#13703

@sumitvekariya
Remove Truffle Suite references as it's being discontinued
70d19bb 
- Removed truffle mention & references from codebase
- Tutorials that were mentioning truffle, removed the section or mention of the truffle
- Tutorials that were relying on truffle have been removed entirely
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program labels Aug 29, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 29, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 70d19bb
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66d00f0817d1350008d20a59
😎 Deploy Preview https://deploy-preview-13738--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 39 (🔴 down 11 from production)
Accessibility: 94 (🟢 up 2 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@corwintines corwintines self-assigned this Sep 4, 2024
@sumitvekariya
Copy link
Contributor Author

Any update on this? Issue it resolves are marked as urgent

@wackerow wackerow added the Update Crowdin PR introduces changes that need to be updated in Crowdin label Sep 16, 2024
wackerow
wackerow approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot @sumitvekariya! Pulling in

@wackerow wackerow merged commit 6d2944c into ethereum:dev Sep 16, 2024
6 checks passed
This was referenced Sep 16, 2024
Closed
Closed
@lukassim lukassim removed the Update Crowdin PR introduces changes that need to be updated in Crowdin label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees

@corwintines corwintines

Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumitvekariya @wackerow @corwintines @lukassim