Homepage: enable atom feeds #13806
Merged
Homepage: enable atom feeds #13806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
Always check for possible string value first before AtomElement struct
pettinarip
approved these changes
Sep 6, 2024
| const [source] = mainChannel.title | ||
| const [sourceUrl] = mainChannel.link | ||
| const channelImage = mainChannel.image ? mainChannel.image[0].url[0] : "" | ||
| const response = (await fetchXml(url)) as RSSResult | AtomResult |
There was a problem hiding this comment.
Not blocker: instead of casting the type you could use type guards
const isRSSFeed = (result: Record<string, unknown>): result is RSSResult => {
return "rss" in result
}
const response = await fetchXml(url)
if (isRSSFeed(response)) {
const parsedRssItems = parseRSSItem(...)
}
...
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends
homepagebranch found in:Description
Related Issue
Homepage epic