-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product table refactor #13807
Product table refactor #13807
Conversation
the tooltips position @wackerow pls check it |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉🎉🎉 Nice job @corwintines! This feels very robust while testing it out.
Found a few tiny nice-to-haves that I do not see as blockers, but will just note here:
- Add
type
to all"@/lib/types"
imports - "Filters" button on mobile has weird focus outline... could consider
-ms-1 ps-1
to shift start edge - Personas on mobile still not totally clear you can scroll to the right for more
- Getting a quick flash/glitch when opening and closing the mobile filter menu (Brave or Safari, iPhone)
- My patch changing the
Icon
attribute forSwitchFilterInput
may not be the most appropriate way to pass a prop, but working for now - Separate PR open for the icon alignment
Approved from dev side. cc: @nloureiro and/or @konopkja for approval from design side 🙏, then can pull this in (ideally before this weeks release if no critical blockers) |
Fix: wallet attributes icon alignments
Going to bring this in with @wackerow review, and approval from @nloureiro and @konopkja in Discord after fixing these last issues. |
Description