Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design system: nav bar/button theming #13825

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Design system: nav bar/button theming #13825

merged 3 commits into from
Sep 10, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Sep 8, 2024 •
edited
Loading

Extends colors-1 branch in PR:

(Can be merged in any order)

Description

  • Touches up nav bar buttons patching color inconsistencies, and updating with latest design system.
  • Patches transition animations (consistent 12deg rotation on hover, and 500ms duration on/off.
  • Adds border-b-disabled for nav bar per Figma

Related Issue

Design system

image

@wackerow wackerow changed the base branch from dev to colors-1 September 8, 2024 02:37
@netlify Netlify
Copy link

netlify bot commented Sep 8, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5d551cb
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66dd0de1408ba700088ddcdf
😎 Deploy Preview https://deploy-preview-13825--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 35 (🔴 down 13 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 86 (🔴 down 6 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow changed the title Colors 1 nav Design system: nav button theming Sep 8, 2024
@wackerow wackerow changed the title Design system: nav button theming Design system: nav bar/button theming Sep 8, 2024
@wackerow wackerow added the design system this label will be used in all issues related to design system label Sep 9, 2024
nloureiro
nloureiro approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@nloureiro nloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome detail. approved

Note for the future: add this animation to all the icons on the dropdown navigation ;)

@pettinarip pettinarip merged commit 5de36e8 into colors-1 Sep 10, 2024
10 checks passed
@pettinarip pettinarip deleted the colors-1-nav branch September 10, 2024 08:15
This was referenced Sep 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nloureiro nloureiro nloureiro approved these changes

@pettinarip pettinarip pettinarip approved these changes

@corwintines corwintines Awaiting requested review from corwintines

@minimalsm minimalsm Awaiting requested review from minimalsm

Assignees
No one assigned
Labels
design system this label will be used in all issues related to design system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wackerow @pettinarip @nloureiro