Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage: add "values" section with marquee #13836

Merged
merged 29 commits into from
Sep 19, 2024
Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Sep 10, 2024

Description

  • Adds Values section ("The Internet is Changing")
  • Adds ValuesMarquee component with animations
  • Includes prefers-reduced-motion alternative styling

Preview link

https://deploy-preview-13836--ethereumorg.netlify.app/en/#values

Relate issue

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Sep 10, 2024
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 8dc29d7
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66ec92062f10a90008f34808
😎 Deploy Preview https://deploy-preview-13836--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 92 (🔴 down 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Sep 10, 2024
@wackerow wackerow marked this pull request as ready for review September 19, 2024 01:51
@wackerow wackerow changed the title WIP: The Internet is Changing component Homepage: add "values" section with marquee Sep 19, 2024
@wackerow wackerow changed the base branch from dev to staging September 19, 2024 03:13
pettinarip
pettinarip previously approved these changes Sep 19, 2024
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -14,6 +14,7 @@

--background: var(--white);
--background-highlight: var(--gray-50);
--background-medium: var(--gray-200); /* TODO: VERIFY */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who should verify this? verify against the DS?

konopkja
konopkja previously approved these changes Sep 19, 2024
corwintines
corwintines previously approved these changes Sep 19, 2024
@corwintines corwintines merged commit b93c5cb into staging Sep 19, 2024
3 checks passed
@corwintines corwintines deleted the internet-is-changing branch September 19, 2024 21:06
This was referenced Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants