Fix: "Select" naming collision #13908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wackerow
requested review from
corwintines,
pettinarip and
minimalsm
as code owners
pettinarip
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Approved to unblock the other PR but I don't think we should keep both selects since they both use react-select and is not clear when to use one or the other. Ideally, we should keep one of them and adjust the instances accordingly. We could tackle this refactor in a different PR if we agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/components/ui/Select/*component up a level to/components/Select/*, a component that follows the pattern of exporting the parent element/components/ui/select.tsxin place, which follows that same pattern of exporting it's exploded partsFixes build errors on #13807
Can separately address deprecating one of these in favor of the other.
Related Issue