Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate: WithdrawalCredentials, feat: add ui/spinner, deprecate: old Input #13924

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

wackerow
Copy link
Member

Description

  • Adds simple ui/spinner component using CgSpinner icon and animate-spin, passing through ref/className to wrapping div
    image
  • Refactors WithdrawalCredentials component to Tailwind
  • Uses ui/alert component with success and error variants to align with DS.
  • Migates to ui/input component
  • Deprecates @/components/Input—no longer being used

Related Issue

  • shadcn migration
  • color theme updates

Copy link

netlify bot commented Sep 21, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 3566ff2
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66ee0eb9701eb70009a30130
😎 Deploy Preview https://deploy-preview-13924--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 6 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pettinarip pettinarip merged commit a8b4188 into dev Sep 23, 2024
8 of 10 checks passed
@pettinarip pettinarip deleted the select-spinner branch September 23, 2024 09:19
This was referenced Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants