Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadcn migration - tag button #13999

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Shadcn migration - tag button #13999

wants to merge 3 commits into from

Conversation

pettinarip
Copy link
Member

Description

Implementation of TagButton to cover hover, focus, active states.

Related Issue

#13972

defihook

This comment was marked as spam.

Base automatically changed from shadcn-tag to dev October 1, 2024 17:19
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Nov 23, 2024
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit cf0d3a8
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6788d6bdac39ef00088aa452
😎 Deploy Preview https://deploy-preview-13999--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🟢 up 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jan 14, 2025
@pettinarip pettinarip marked this pull request as ready for review January 16, 2025 12:38
@nloureiro
Copy link
Contributor

@pettinarip, how can I see this on the browser?

@pettinarip
Copy link
Member Author

@pettinarip, how can I see this on the browser?

Ah sorry. You can see this in the generated storybook under molecules/display-content/new-tags/style-variants-button. Here

@nloureiro
Copy link
Contributor

@pettinarip, how can I see this on the browser?

Ah sorry. You can see this in the generated storybook under molecules/display-content/new-tags/style-variants-button. Here

they look great! let's go!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants