Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RTL styling for ValuesMarquee #14020

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 2, 2024

Target: staging

Description

  • Force dir="ltr" on marquee Row to fix animation issues with translateX
  • Pass the locale direction directly to the Item to correct the text direction

Preview link

https://deploy-preview-14020--ethereumorg.netlify.app/fa/#values

Related Issue

RTL Bug:
image

With fix:
image

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 6acf719
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/66fd18a88cd214000833200f
😎 Deploy Preview https://deploy-preview-14020--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow changed the base branch from dev to staging October 2, 2024 15:39
@corwintines corwintines merged commit 7e52a62 into staging Oct 2, 2024
8 of 10 checks passed
@corwintines corwintines deleted the home-values-rtl-fix branch October 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants