Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: i18n import regressions #14180

Merged
merged 7 commits into from
Oct 23, 2024
Merged

revert: i18n import regressions #14180

merged 7 commits into from
Oct 23, 2024

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Oct 17, 2024 •
edited
Loading

Description

Remove regressions in imported translations

  • Remove Truffle Suite references from imported translations
  • Remove Atom Editor from IDE List page
  • Update 0chain info

Related Issues

Truffle Suite references

Atom editor

0chain info

Related Issue

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Oct 17, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit e4d79bc
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6711423f75475d0008aa8a9f
😎 Deploy Preview https://deploy-preview-14180--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 51 (🔴 down 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wackerow wackerow changed the title I18n regressions revert: i18n import regressions Oct 17, 2024
@wackerow wackerow marked this pull request as ready for review October 17, 2024 17:00
@corwintines corwintines self-assigned this Oct 23, 2024
@corwintines corwintines merged commit 5d130d2 into dev Oct 23, 2024
6 checks passed
@corwintines corwintines deleted the i18n-regressions branch October 23, 2024 04:14
This was referenced Oct 23, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees

@corwintines corwintines

Labels
content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wackerow @corwintines @lukassim