Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate Layer2ProductCard to tailwind and shadcn #14233

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

kushagrasarathe
Copy link
Contributor

Migrates Layer2ProductCard component to tailwind css and shadcn-ui from Chakra

Description

This PR updates the Layer2ProductCard to use tailwind-css and shadcn-ui components instead of Chakra ui. Styles have been updated for both light and dark version.

Related Issue

#13946

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9e9ed13
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/676a9f92a81d7e00087e0a7d
😎 Deploy Preview https://deploy-preview-14233--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🔴 down 7 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (🟢 up 30 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kushagrasarathe kushagrasarathe mentioned this pull request Oct 25, 2024
65 tasks
@isabelladebrito isabelladebrito added the hacktoberfest Track hacktoberfest activity label Oct 28, 2024
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @kushagrasarathe, looks good overall. We just need to use some existing components and we are good to go.

src/components/ui/button.tsx Outdated Show resolved Hide resolved
src/components/Layer2ProductCard.tsx Outdated Show resolved Hide resolved
src/components/Layer2ProductCard.tsx Outdated Show resolved Hide resolved
src/components/Layer2ProductCard.tsx Outdated Show resolved Hide resolved
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kushagrasarathe!

@pettinarip pettinarip merged commit 94d12a8 into ethereum:dev Dec 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants