Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2 revamp #14251

Merged
merged 183 commits into from
Dec 5, 2024
Merged

L2 revamp #14251

merged 183 commits into from
Dec 5, 2024

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Oct 29, 2024

Description

L2 hub
L2 learn
L2 networks
Find walletes

Related Issue

fixes #13062

@nloureiro
Copy link
Contributor

The robust filter is not working

Screen.Recording.2024-12-03.at.08.54.08.mov

@pettinarip
Copy link
Member

Small issue I found when playing with the networks table.

  1. expand a row
  2. change the filters
  3. a different row will be display as expanded
    Screencast from 2024-12-04 17-22-42.webm

IMO we should do one of the following:

  • close all the expanded rows
  • or keep expanded the rows that were expanded (we might need to have an id per row)

@pettinarip
Copy link
Member

We are missing one translation in the quiz label
image

@pettinarip
Copy link
Member

Not sure if this is on purpose or not, but I think we are missing the Filters button in mobile

image

while in the wallets table we display it next to the results counter
image

@corwintines
Copy link
Member Author

As per conversation with @pettinarip and @konopkja in standup today, going to bring this in

@corwintines corwintines merged commit fd962ba into dev Dec 5, 2024
8 of 10 checks passed
@corwintines corwintines deleted the l2revamp branch December 5, 2024 06:50
This was referenced Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethinking L2 information on ethereum.org
5 participants