Add Coin98 Wallet Extensions #14319
Closed
Add Coin98 Wallet Extensions #14319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khiemsoft
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
2 tasks
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
konopkja
reviewed
Nov 6, 2024
src/data/wallets/wallet-data.ts
Outdated
| social_recovery: false, | ||
| onboard_documentation: "https://docs.coin98.com/", | ||
| documentation: "https://docs.coin98.com/", | ||
| new_to_crypto: true, |
There was a problem hiding this comment.
Suggested change
| new_to_crypto: true, |
There was a problem hiding this comment.
this metadata is only assigned by the core team upon careful ux review, not by wallet providers
There was a problem hiding this comment.
@konopkja Already submitted your fixed suggestion, thanks for your review.
minimalsm
reviewed
Nov 21, 2024
minimalsm
approved these changes
Nov 21, 2024
minimalsm
requested changes
Nov 21, 2024
src/data/wallets/wallet-data.ts
Outdated
| social_recovery: false, | ||
| onboard_documentation: "https://docs.coin98.com/", | ||
| documentation: "https://docs.coin98.com/", | ||
| new_to_crypto: true, |
There was a problem hiding this comment.
@khiemsoft please remove this field per @konopkja's comment. I don't have write access to this PR or I'd do it myself :)
Could you also clear merge conflicts and I'll get this merged?
Thanks 👍
Suggested change
| new_to_crypto: true, |
There was a problem hiding this comment.
@minimalsm Already submitted your fixed suggestion; thanks for your review.
github-actions
bot
added
the
abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet description
Coin98 Super Wallet is the leading multi-chain crypto & AI wallet, designed to seamlessly connect users to the crypto world safely and securely.
We now support 120+ networks, including EVMs and non-EVM chains. With 10M+ users in over 170 countries, Coin98 Super Wallet is fulfilling untapped demand and enhancing in-demand utilities in the DeFi space, helping people to access DeFi services effortlessly.