Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wallet-data.ts - pillar #14540

Closed
wants to merge 1 commit into from

Conversation

Shiva-Sai-ssb
Copy link
Contributor

Description

Related Issue

Closes #14360

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 7e423dd
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/676901900a5a3e00083b55ce
😎 Deploy Preview https://deploy-preview-14540--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🔴 down 6 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (🟢 up 30 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@konopkja
Copy link
Contributor

konopkja commented Dec 23, 2024

Hi @Shiva-Sai-ssb im so sorry but the wallet provider just submitted their own PR and I think its better to prefer merging theirs.

I appreciate you willingness to help and your effort, next time i will make sure this doesnt happen again.

❤️

@konopkja konopkja closed this Dec 23, 2024
@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label Dec 23, 2024
@Shiva-Sai-ssb
Copy link
Contributor Author

Hi @Shiva-Sai-ssb im so sorry but the wallet provider just submitted their own PR and I think its better to prefer merging theirs.

I appreciate you willingness to help and your effort, next time i will make sure this doesnt happen again.

❤️

Hi @konopkja, no worries! I completely understand the decision to prefer their PR. Thank you for letting me know.

@Shiva-Sai-ssb Shiva-Sai-ssb deleted the fix-14360 branch December 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned This has been abandoned or will not be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggest a wallet
2 participants