Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Pillar Wallet [Fixes #14360] #14543

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

arddluma
Copy link

Description

Updated Pillar Wallet logo and features

Related Issue

#14360

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit cf8646f
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6769891c88875000084a8ef2
😎 Deploy Preview https://deploy-preview-14543--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 52 (🔴 down 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (🟢 up 30 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexandradev alexandradev mentioned this pull request Dec 23, 2024
2 tasks
twBackgroundColor: "bg-[#7501D9]",
twGradiantBrandColor: "from-[#7501D9]",
twBackgroundColor: "bg-[#6A12D0]",
twGradiantBrandColor: "from-[#6A12D0]",
url: "https://www.pillar.fi/",
active_development_team: true,
languages_supported: ["en", "bs", "zh"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
languages_supported: ["en", "bs", "zh"],
languages_supported: ["en"],

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the #14360 I see only english support, @arddluma and @alexandradev can you confirm and modify this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello there,
Please check this screenshot from pillar wallet
IMG_1882

Copy link
Contributor

@konopkja konopkja Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see, so the issue was filled out incorrectly?

Copy link
Author

@arddluma arddluma Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, apologies for that!

Copy link
Contributor

@konopkja konopkja Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok no worries, i see 4 languages on the screenshot while only 3 in the metadata, could you pls update it with the missing lang code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done sir, the missing language is Amharic. I have just added it, do you mind checking it please?

Copy link
Contributor

@konopkja konopkja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants