Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Staking Guides to shadcn #14592

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

plvzfq-rit
Copy link
Contributor

Description

Changed original Stack with CardList attributes into a CardList with Stack attributes, i.e., from

<Stack as={CardList} direction="column" gap={4} items={guides}>

to

<CardList className="flex flex-col gap-4" items={guides} />

Related Issue

#13946

Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2214d45
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67750d8b79f1ff000888993b
😎 Deploy Preview https://deploy-preview-14592--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 50 (🔴 down 5 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (🟢 up 30 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip mentioned this pull request Jan 6, 2025
39 tasks
@pettinarip
Copy link
Member

@plvzfq-rit is this PR ready for review? asking because it is in draft mode

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@plvzfq-rit
Copy link
Contributor Author

Ah, I was not sure if the approach was good or not, but I think it should be good now yes, apologies for that;;;

@plvzfq-rit plvzfq-rit marked this pull request as ready for review January 7, 2025 15:35
@pettinarip pettinarip merged commit 8028e16 into ethereum:dev Jan 8, 2025
10 checks passed
This was referenced Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants