Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txCosts using layer2Data #14616

Merged
merged 1 commit into from
Jan 8, 2025
Merged

txCosts using layer2Data #14616

merged 1 commit into from
Jan 8, 2025

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Jan 7, 2025 •
edited
Loading

Description

  • Had an issue where the average txCosts was using all networks from growthepie, but we only show some of the networks. Filtering this down now so that the average costs reflects the networks we show on ethereum.org

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Jan 7, 2025
@corwintines corwintines changed the title txCosts using layer2Data instead of all network data for consistent a… txCosts using layer2Data Jan 7, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit f529512
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/677d9f1e502f2f0008a46457
😎 Deploy Preview https://deploy-preview-14616--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 43 (🔴 down 12 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Ahmednurmuhiyadin
Ahmednurmuhiyadin approved these changes Jan 7, 2025
View reviewed changes
Copy link

@Ahmednurmuhiyadin Ahmednurmuhiyadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INVESTOR AHMEDNUR

@pettinarip pettinarip merged commit a84acbe into dev Jan 8, 2025
6 checks passed
@pettinarip pettinarip deleted the l2StatFix branch January 8, 2025 11:06
This was referenced Jan 8, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ahmednurmuhiyadin Ahmednurmuhiyadin Ahmednurmuhiyadin approved these changes

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
tooling 🔧 Changes related to tooling of the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corwintines @pettinarip @Ahmednurmuhiyadin