Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate Card to tailwind #14683

Merged
merged 2 commits into from
Jan 30, 2025
Merged

feat: migrate Card to tailwind #14683

merged 2 commits into from
Jan 30, 2025

Conversation

corwintines
Copy link
Member

Description

  • Migrate src/components/Card/index.tsx from Chakra to tailwind
  • Fixes uses of this component to also be tailwind

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit bdc92da
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/679a1483557f2a00088b9e8a
😎 Deploy Preview https://deploy-preview-14683--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 47 (🔴 down 1 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corwintines left a couple of comments related to colors before we move forward with it.

src/components/Card/index.tsx Outdated Show resolved Hide resolved
src/components/Card/index.tsx Outdated Show resolved Hide resolved
src/styles/semantic-tokens.css Outdated Show resolved Hide resolved
tailwind.config.ts Outdated Show resolved Hide resolved
@pettinarip pettinarip merged commit f0fc8b7 into dev Jan 30, 2025
10 checks passed
@pettinarip pettinarip deleted the card-shadcn branch January 30, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants