Skip to content

Patch low contrast text in banner #15662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Patch low contrast text in banner #15662

merged 1 commit into from
Jun 25, 2025

Conversation

pettinarip
Copy link
Member

from:
image

to:
image

Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 1abbdb8
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/684b01baa91e840008b778d7
😎 Deploy Preview https://deploy-preview-15662--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 9 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 91 (🔴 down 7 from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@wackerow
Copy link
Member

wackerow commented Jun 18, 2025

Hey @pettinarip, where are you seeing this bug? Which browser? I'm not seeing it, and noting we already have this applied to the BannerNotification wrapper:

"flex w-full items-center justify-center gap-2 bg-primary-action px-8 py-4 text-white [&_a]:text-white [&_a]:hover:text-white/80",

The [&_a] selector classes were put in place to override the links in this component due to bg-primary-action... are we sure this change is needed?

@corwintines corwintines merged commit b90cb47 into dev Jun 25, 2025
11 checks passed
@corwintines corwintines deleted the patch-low-contrast branch June 25, 2025 13:54
This was referenced Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants