Skip to content

fix: "Link component missing href prop" build warnings #15715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 25, 2025
Merged

fix: "Link component missing href prop" build warnings #15715

merged 7 commits into from
Jun 25, 2025

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Jun 24, 2025 •
edited
Loading

Description

  • Migrate old to props to href
  • Remove near-empty markdown pages with broken syntax from Crowdin
  • Increment headers where a second # h1 was found causing href link errors
  • Add missing custom header ids to organizing page, and fix multiple-h1
  • bump pnpm version

Related Issue

None filed

@wackerow
fix: href link props; rm empty md pages
65f1a97 
Fixes build warnings for "Link component missing href prop", "Codeblock children is not valid",
@netlify Netlify
Copy link

netlify bot commented Jun 24, 2025 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 953ec5e
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/685b4b2af9c83a0008844f79
😎 Deploy Preview https://deploy-preview-15715--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 39 (🔴 down 19 from production)
Accessibility: 95 (🟢 up 1 from production)
Best Practices: 91 (🔴 down 8 from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Jun 24, 2025
@wackerow wackerow force-pushed the fix-build-warnings branch from 618aac9 to d2aba02 Compare June 25, 2025 00:06
@wackerow wackerow changed the title fix: href link props; rm empty md pages fix: "Link component missing href prop" build warnings Jun 25, 2025
@github-actions github-actions bot added the dependencies 📦 Changes related to project dependencies label Jun 25, 2025
@corwintines corwintines merged commit 1fee146 into dev Jun 25, 2025
7 checks passed
@corwintines corwintines deleted the fix-build-warnings branch June 25, 2025 13:50
This was referenced Jun 25, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwintines corwintines corwintines approved these changes

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits dependencies 📦 Changes related to project dependencies translation 🌍 This is related to our Translation Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wackerow @corwintines