-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Documentation updates #16085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Documentation updates #16085
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@corwintines Hi! chek my PR plz?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL updates are fine, but left a comment on the name updates.
- [123ETH](https://123eth.org/) - a Portal to the Ethereum ecosystem | ||
- [Zhen Xiao](http://zhenxiao.com/blockchain/) - free online courses about cryptocurrency and its applications | ||
- [Ethereum Whitepaper](https://github.com/ethereum/wiki/wiki/[%E4%B8%AD%E6%96%87]-%E4%BB%A5%E5%A4%AA%E5%9D%8A%E7%99%BD%E7%9A%AE%E4%B9%A6) - Chinese version of the Ethereum Whitepaper | ||
- [Ethereum Whitepaper](https://ethereum.org/zh/developers/docs/) - Chinese version of the Ethereum Whitepaper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the https://ethereum.org domain prefix here, and also this should point to the whitepaper, not the docs
- [Ethereum Whitepaper](https://ethereum.org/zh/developers/docs/) - Chinese version of the Ethereum Whitepaper | |
- [Ethereum Whitepaper](/zh/whitepaper/) - Chinese version of the Ethereum Whitepaper |
For this to work properly, may need to pull in the latest from dev
branch as well which has some updates to the way locale routing is handled.
If you have a Discord server or Telegram channel, it is easy to use that for outreach, communication with your translators, and acknowledging your contributors. | ||
|
||
Platforms like Twitter can also be helpful for onboarding new community members and publicly acknowledging your contributors. | ||
Platforms like X can also be helpful for onboarding new community members and publicly acknowledging your contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the new plain name of Twitter is painful on the eyes. Personally in favor of reverting the entire site back to just "Twitter" despite their changes. Or, at the very least, X (formerly Twitter)
, X/Twitter
, or X (Twitter)
so it's at least readable,
Hi,
Just a quick PR to correct a few minor errors.
Thanks!)