Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support chain_id in loading multi-transaction state tests #1023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 20, 2024

Also set default chain_id to 1 - see confirmation that this is expected behavior https://discord.com/channels/595666850260713488/753271902520213625/1280839101687533619

Pulled out of #961, required for 7702 tests.

@gumb0 gumb0 marked this pull request as ready for review September 20, 2024 13:15
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.19%. Comparing base (bae4933) to head (7f2c594).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1023   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         149      149           
  Lines       15887    15888    +1     
=======================================
+ Hits        14964    14965    +1     
  Misses        923      923           
Flag Coverage Δ
eof_execution_spec_tests 17.24% <60.00%> (+<0.01%) ⬆️
ethereum_tests 27.33% <60.00%> (+<0.01%) ⬆️
ethereum_tests_silkpre 19.13% <40.00%> (+0.01%) ⬆️
execution_spec_tests 20.42% <60.00%> (+<0.01%) ⬆️
unittests 88.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
test/statetest/statetest_loader.cpp 96.85% <100.00%> (+0.01%) ⬆️
test/unittests/statetest_loader_test.cpp 100.00% <100.00%> (ø)
test/unittests/statetest_loader_tx_test.cpp 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant