Updates to BLS precompiles (EIP-2537) #1089
Draft
+62
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
added
precompiles
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1089 +/- ##
==========================================
- Coverage 94.31% 93.58% -0.73%
==========================================
Files 159 159
Lines 17221 17207 -14
==========================================
- Hits 16242 16104 -138
- Misses 979 1103 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This updates the gas costs of BLS precompiles. Discounts tables for MSMs are not split between G1 and G2 variants. We additionally pre-process the tables to more directly consumable form.
Remove redundant G1/G2 MUL precompiles easily replaceable with MSMs. Spec update: ethereum/EIPs#8945.
chfast
force-pushed
the
precompiles/bls_updates
branch
from
9971bd0 to
6e214c6
Compare
rodiazet
requested changes
Jan 15, 2025
| 524, 523, 522, 522, 521, 520, 520, 519}; | ||
| static constexpr auto POINT_COSTS = | ||
| bls12_msm_discounts_to_point_costs(G1MUL_GAS_COST, DISCOUNTS); | ||
|
|
||
| if (input.empty() || input.size() % 160 != 0) |
There was a problem hiding this comment.
Can we define single input size and use ut here and below? Same for G2
| @@ -176,7 +158,7 @@ PrecompileAnalysis point_evaluation_analyze(bytes_view, evmc_revision) noexcept | |||
|
|
|||
| PrecompileAnalysis bls12_g1add_analyze(bytes_view, evmc_revision) noexcept | |||
| { | |||
| static constexpr auto BLS12_G1ADD_PRECOMPILE_GAS = 500; | |||
| static constexpr auto BLS12_G1ADD_PRECOMPILE_GAS = 375; | |||
There was a problem hiding this comment.
If we are not going to squash the commits before merging this change should go to different commit.
There was a problem hiding this comment.
Same applies to g2add, g2mul, pairing, g2 map analysis
| @@ -443,20 +443,6 @@ ExecutionResult bls12_g1add_execute(const uint8_t* input, size_t input_size, uin | |||
| return {EVMC_SUCCESS, 128}; | |||
| } | |||
|
|
|||
| ExecutionResult bls12_g1mul_execute(const uint8_t* input, size_t input_size, uint8_t* output, | |||
There was a problem hiding this comment.
Remove also their analysis counterparts for g1 and g2. Here and from the header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply recent EIP-2537 spec updates: