-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evmmax: Implementation of vectorized version od EVMMAX opcodes (EIP-6690) #1120
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
- Coverage 94.50% 94.45% -0.05%
==========================================
Files 167 169 +2
Lines 18193 18650 +457
==========================================
+ Hits 17193 17616 +423
- Misses 1000 1034 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Nice! Would it be unreasonable to, instead of 2 branches, just have both options (vectorized and not) available on 1 branch, with opcodes assigned somewhere arbitrarily and with heavily copy-pasted code? Or even same opcodes but a feature flag on the |
Good point. I can think of some c++ macro which enables requested version or maybe introduce a runtime flag. |
646e1aa
to
8e8e020
Compare
f0a4caf
to
a4ef7ea
Compare
test: Omit new opcodes with immediate params in unit tests
a4ef7ea
to
af85f49
Compare
This PR implements PoC version of EVMMAX according to EIP-6690 (called vectorized, SIMD or sequential version).
Gas model is not updated to how the EIP defines it.