Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests): export 'chain_id' in fixture config #1131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(tests): export 'chain_id' in fixture config #1131

wants to merge 2 commits into from

Conversation

winsvega
Copy link
Contributor

@winsvega winsvega commented Jan 27, 2025 •
edited
Loading

🗒️ Description

export chain id and network to the test config field so it won't be empty in state tests

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega changed the title export fork and chain id fixture config feat(tests): export 'fork' and 'chain_id' in fixture config Jan 27, 2025
@winsvega winsvega requested a review from marioevz January 27, 2025 11:32
@winsvega winsvega added type:feat type: Feature scope:tests Scope: Changes EL client test cases in `./tests` labels Jan 27, 2025
marioevz
marioevz reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments, and we need to add these fields to the documentation, but I can help out with that.

src/ethereum_test_fixtures/blockchain.py Outdated Show resolved Hide resolved
src/ethereum_test_fixtures/state.py Outdated Show resolved Hide resolved
@marioevz marioevz mentioned this pull request Jan 30, 2025
Open
@winsvega winsvega mentioned this pull request Feb 3, 2025
Closed
4 tasks
@winsvega
Copy link
Contributor Author

winsvega commented Feb 3, 2025 •
edited
Loading

need to add into hive too
src/pytest_plugins/consume/hive_simulators/conftest.py line 150

@winsvega winsvega changed the title feat(tests): export 'fork' and 'chain_id' in fixture config feat(tests): export 'chain_id' in fixture config Feb 5, 2025
@winsvega winsvega self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz Awaiting requested review from marioevz

@danceratopz danceratopz Awaiting requested review from danceratopz

At least 1 approving review is required to merge this pull request.

Assignees

@winsvega winsvega

Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winsvega @marioevz @danceratopz