Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): EIP-6110: Add slow marker to many_deposits test #1160

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

marioevz
Copy link
Member

πŸ—’οΈ Description

Mark the many_deposits tests as slow due to timeouts that have been happening when filling using max parallelism.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. Skip.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:tests Scope: Changes EL client test cases in `./tests` labels Jan 30, 2025
@marioevz marioevz force-pushed the mark-long-deposits-test-as-slow branch from a903f2a to ca0bdec Compare January 30, 2025 17:13
Copy link
Contributor

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it disabled by default?

@marioevz
Copy link
Member Author

Is it disabled by default?

Not really, but it's sometimes useful to use -m "not slow" if you want to quickly fill tests for local testing purposes.

It also increases the timeout from the t8n server for the marked test.

@marioevz marioevz merged commit fef9a26 into main Jan 31, 2025
34 checks passed
@marioevz marioevz deleted the mark-long-deposits-test-as-slow branch January 31, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants