Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on evm tracing for EELS #1174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fselmo
Copy link
Contributor

@fselmo fselmo commented Feb 4, 2025

๐Ÿ—’๏ธ Description

  • Always send trace, and if it's set to True, send a known temp directory output-basedir to the EELS server / daemon. The server will include the full trace, using the output-basedir to storeย  the trace .jsonl files to be collected as expected by EEST.

๐Ÿ”— Related Issues

ethereum/execution-specs#1109

โœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • n/a Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • n/a Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • n/a Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • n/a Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@fselmo fselmo added scope:evm Scope: evm_transition_tool package type:feat type: Feature t8ntools Third party t8n tools support labels Feb 4, 2025
@fselmo fselmo self-assigned this Feb 4, 2025
@fselmo fselmo marked this pull request as ready for review February 4, 2025 15:44
@fselmo
Copy link
Contributor Author

fselmo commented Feb 4, 2025

I left a comment on ethereum/execution-specs#1109 but it looks like merging into master there will cause conflicts with ethereum.rlp. Which branches would be best to PR against between EELS and EEST?


edit: maybe the add-ethereum-rlp-with-uv-0.5.15 branch here?

@fselmo fselmo changed the title Turn on evm tracing for EELS: Turn on evm tracing for EELS Feb 4, 2025
@danceratopz
Copy link
Member

I left a comment on ethereum/execution-specs#1109 but it looks like merging into master there will cause conflicts with ethereum.rlp. Which branches would be best to PR against between EELS and EEST?

edit: maybe the add-ethereum-rlp-with-uv-0.5.15 branch here?

@fselmo thanks for this!

The background is:

  • Sam created a new RLP library, https://pypi.org/project/ethereum-rlp/.
  • execution-specs master now uses this library instead of the previously locally (to execution-specs) implemented ethereum.rlp.
  • execution-spec-tests uses an older version of execution-specs (pinned in uv.lock) and still uses ethereum.rlp instead of ethereum-rlp.

I'll need to double-check, but I think we only need to move EEST from ethereum.rlp to the new ethereum-rlp package and then we can bump our dependencies to the current master ref of execution-specs.

I'll have go at moving EEST to ethereum-rlp.

@fselmo
Copy link
Contributor Author

fselmo commented Feb 5, 2025

Thanks @danceratopz for the background. I knew there was an update needed somewhere, was just unsure which branch made sense here but that clears it up ๐Ÿ‘๐Ÿผ

- Always send ``trace``, and if it's set to ``True``, send a known
  temp ``output-basedir`` to the EELS server / daemon. The server
  will include the full trace, using the ``output-basedir`` to store
  the trace ``.jsonl`` files to be collected as expected by EEST.
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, we have to wait until the EELS PR is merged, and include an updated reference to the new EELS commit in this PR, just like #1181 did.

@winsvega
Copy link
Contributor

once we have access to evm tracing, can we add expect verification type for a certain type of exception during vm exec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:evm Scope: evm_transition_tool package t8ntools Third party t8n tools support type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants