-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on evm tracing for EELS #1174
base: main
Are you sure you want to change the base?
Conversation
I left a comment on ethereum/execution-specs#1109 but it looks like merging into edit: maybe the |
@fselmo thanks for this! The background is:
I'll need to double-check, but I think we only need to move EEST from I'll have go at moving EEST to ethereum-rlp. |
Thanks @danceratopz for the background. I knew there was an update needed somewhere, was just unsure which branch made sense here but that clears it up ๐๐ผ |
- Always send ``trace``, and if it's set to ``True``, send a known temp ``output-basedir`` to the EELS server / daemon. The server will include the full trace, using the ``output-basedir`` to store the trace ``.jsonl`` files to be collected as expected by EEST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, we have to wait until the EELS PR is merged, and include an updated reference to the new EELS commit in this PR, just like #1181 did.
once we have access to evm tracing, can we add expect verification type for a certain type of exception during vm exec? |
๐๏ธ Description
trace
, and if it's set toTrue
, send a known temp directoryoutput-basedir
to the EELS server / daemon. The server will include the full trace, using theoutput-basedir
to storeย the trace.jsonl
files to be collected as expected by EEST.๐ Related Issues
ethereum/execution-specs#1109
โ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.