Skip to content

chore(tooling): point to new coverage script #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

felix314159
Copy link
Collaborator

@felix314159 felix314159 commented Jun 23, 2025

πŸ—’οΈ Description

Replaces this coverage script with the clone located here. You can see that the hash is identical, but we still have to replace our secrets.DOCKERHUB_PASSWORD with my PAT (public read only). DM me for this, it can be done via GitHub GUI (GitHub repo β†’ Settings β†’ Secrets and variables β†’ Actions).

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@danceratopz danceratopz added type:chore Type: Chore scope:tooling Scope: Python tools (uv, ruff, tox,...) labels Jun 23, 2025
@danceratopz danceratopz changed the title tooling(chores): point to new coverage script chore(tooling): point to new coverage script Jun 23, 2025
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marioevz
Copy link
Member

This is being taken care of by #1761, which also modifies the script to be compatible with the fill output.

@danceratopz
Copy link
Member

Thanks @felix314159, closing in favor of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tooling Scope: Python tools (uv, ruff, tox,...) type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants