Skip to content

chore(ci): update pr template #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025
Merged

chore(ci): update pr template #1805

merged 3 commits into from
Jun 27, 2025

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Jun 25, 2025

🗒️ Description

Updates our PR template. Only added some small tweaks. Will leave open for discussion.

Edit: updates added from @danceratopz. Can discuss more in tmo's meeting for final edits.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

@spencer-tb spencer-tb added type:chore Type: Chore type:docs Type: Changes to the documentation labels Jun 25, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Couple of suggestions below!

@spencer-tb spencer-tb force-pushed the update-pr-template branch from 8ebab6f to 3ad3500 Compare June 25, 2025 15:51
@danceratopz danceratopz added scope:ci Scope: Continuous Integration and removed type:docs Type: Changes to the documentation labels Jun 25, 2025
@danceratopz danceratopz changed the title chore(docs): update pr template chore(ci): update pr template Jun 25, 2025
@spencer-tb spencer-tb force-pushed the update-pr-template branch from 3ad3500 to 013f205 Compare June 25, 2025 16:05
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this! :)

@spencer-tb spencer-tb marked this pull request as ready for review June 25, 2025 17:39
@spencer-tb
Copy link
Contributor Author

Will keep open until tmo's meeting incase anyone wants to add/remove anything else. :)

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised that the new links in comments make little sense (they won't render). Please find an updated suggestion below; here's how it looks:

image

@spencer-tb spencer-tb force-pushed the update-pr-template branch from df34297 to 917026f Compare June 26, 2025 17:53
@danceratopz danceratopz merged commit 851f9f5 into main Jun 27, 2025
27 checks passed
@danceratopz danceratopz deleted the update-pr-template branch June 27, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants