Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): EIP-7620,EIP-3540: Failing EOF tests #594

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 5, 2024

🗒️ Description

Makes the following fixes:

  • test_code_section_header_body_mismatch: Change expected exception from EOFException.INVALID_SECTION_BODIES_SIZE -> EOFException.INVALID_TYPE_SECTION_SIZE
  • test_legacy_initcode_invalid_eof_v1_contract::trailing_bytes_after_data_section: Correct output (NON_RETURNING_SECTION) in code section
  • test_eofcreate_deploy_sizes::64k-1 skip test due to oversized container in the pre-alloc.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases type:chore Type: Chore labels Jun 5, 2024
@marioevz
Copy link
Member Author

marioevz commented Jun 6, 2024

PTAL @shemnon @chfast @gumb0

@marioevz marioevz merged commit cca7878 into ethereum:main Jun 6, 2024
5 checks passed
@marioevz marioevz deleted the fix-eof-tests branch June 6, 2024 16:30
@pdobacz
Copy link
Collaborator

pdobacz commented Jun 10, 2024

@marioevz Just FYI, due to issues around

test_eofcreate_deploy_sizes::64k-1 skip test due to oversized container in the pre-alloc.

we're considering putting a hard limit on the container size during eof validation, c.f. ipsilon/eof#125 . This would define the maximum expected size to handle in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants