Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-3540: MAX_INITCODE_SIZE validation #630

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Jun 17, 2024

🗒️ Description

Add tests aligning with ethereum/EIPs#8670 / ipsilon/eof#125

🔗 Related Issues

na

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I feel like the eof_test test type is not enough to test the initcode and deployed code max sizes. I feel like we require state tests for this, where we use contract-creating txs to test the maximum initcode size, and contract-creating txs + eofcreate to test the maximum size of deployed containers.

@pdobacz
Copy link
Collaborator Author

pdobacz commented Jun 19, 2024

In general I feel like the eof_test test type is not enough to test the initcode and deployed code max sizes. I feel like we require state tests for this, where we use contract-creating txs to test the maximum initcode size, and contract-creating txs + eofcreate to test the maximum size of deployed containers.

Agreed. This PR only adds tests for a specific addition from the PR cited, not meant to be exhaustive. The tests which you mention will be covered in the 7620 / 7698 tests department

@pdobacz pdobacz force-pushed the add-3540-tests branch 3 times, most recently from e49d60f to 113b9f4 Compare June 24, 2024 09:57
@pdobacz
Copy link
Collaborator Author

pdobacz commented Jun 25, 2024

This is ready to be reviewed. @marioevz would you like to take a look?

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some comments, I'll apply them and merge.

@marioevz marioevz changed the title Add tests for EIP-3540 - MAX_INITCODE_SIZE validation new(tests): EOF - EIP-3540: MAX_INITCODE_SIZE validation Jun 27, 2024
@marioevz marioevz merged commit 7139105 into ethereum:main Jun 27, 2024
4 checks passed
@marioevz marioevz deleted the add-3540-tests branch June 27, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants