-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(fixtures): Remove formats.py
, embed properties as class vars
#826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
added
type:chore
Type: Chore
type:refactor
Type: Refactor
scope:fw
Scope: Framework (evm|tools|forks|pytest)
labels
Sep 20, 2024
marioevz
commented
Sep 20, 2024
8 tasks
danceratopz
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean-up! In particular to fill's pytest_collection_modifyitems()
! I'd just add a small comment to help the reader.
LGTM.
marioevz
force-pushed
the
fixture-formats-method-refactor
branch
from
September 24, 2024 23:10
a9b8ad6
to
e1fb88a
Compare
marioevz
changed the title
refactor(fixtures): Embed FixtureFormat methods in instance
refactor(fixtures): Remove Sep 24, 2024
formats.py
, embed properties as class vars
marioevz
force-pushed
the
fixture-formats-method-refactor
branch
from
September 30, 2024 15:21
23275e8
to
d7ad4f8
Compare
marioevz
force-pushed
the
fixture-formats-method-refactor
branch
from
September 30, 2024 21:05
d7ad4f8
to
613ce89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:fw
Scope: Framework (evm|tools|forks|pytest)
type:chore
Type: Chore
type:refactor
Type: Refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
MinorMajor refactor to theethereum_test_fixtures
where each subclass ofBaseFixture
now contains all the properties of the format, and thereforeethereum_test_fixtures/formats.py
is not longer necessary (nor is the Enum it defined).FixtureFormats
was widely used across many places in several libraries, hence the high number of files changed, but the changes are relatively minor.🔗 Related Issues
None
✅ Checklist
All: Added an entry to CHANGELOG.md.skippedmkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.