-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fw,tests): EIP-6110, EIP-7002, EIP-7251, EIP-7702: Pectra Devnet-4 updates #832
Conversation
5ee7a97
to
35a8be9
Compare
77b36d1
to
5fd9880
Compare
2f9d2b0
to
de37130
Compare
I do not see this PR listed: This might seem like a no-op but this strictly checks that the |
f99fec5
to
34016d2
Compare
f49210a
to
f5799c8
Compare
Co-authored-by: Jochem Brouwer <[email protected]>
b7dd3cb
to
a7f0eca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm happy with this. I've spent a lot of today review it to copy pasta some items for 7742
🗒️ Description
Extra New Tests
Breaking Changes
T8N Interface
result
object (returned by the transition tool) fieldsdeposit_requests
,withdrawal_requests
andconsolidation_requests
are deprecated and substituted by fieldrequests
which contains a list of hex strings (due to engine: Make execution requests a sidecar, take 2 execution-apis#591), where each element represents the output of the requests contract (requests_data
).result
object fieldrequests_root
has been renamed torequests_hash
, and the value of this field needs to be updated to be calculated assha256(sha256(requests_0) ++ sha256(requests_1) ++ ...)
, whererequests_0 = request_type_0 ++ request_data_0
Blockchain Fixtures Changes
blockHeader.requests_root
field has been renamed torequests_hash
in theblockchain_test
fixture type.FixtureBlockBase
andFixtureExecutionPayload
fieldsdeposit_requests
,withdrawal_requests
andconsolidation_requests
arereplaced by a single fieldremoved.requests
, containing a list of hex strings, where each element represents the bytes of a flattened requestFixtureEngineNewPayload.params
which represents the flattened requests.🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.