Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fw): EOF - Fix EXCHANGE's data_portion_length #849

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pdobacz
Copy link
Collaborator

@pdobacz pdobacz commented Sep 30, 2024

πŸ—’οΈ Description

Just a minor issue I've noticed. It didn't affect any bytecode generation, but fixing anyway

πŸ”— Related Issues

NA

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@@ -5066,6 +5066,7 @@ class Opcodes(Opcode, Enum):

EXCHANGE = Opcode(
0xE8,
data_portion_length=1,
Copy link
Collaborator Author

@pdobacz pdobacz Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late thought - one could also derive it dynamically as len(data_portion_formatter(args)) in __getitem__, please advise if this is better. This should cover RJUMPV as well then.

@danceratopz
Copy link
Member

danceratopz commented Sep 30, 2024

Hi @pdobacz, the initial CI fail has been fixed by #850 so I merged main into this branch. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants