Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ethereum-rlp #1034

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

SamWilsn
Copy link
Collaborator

What was wrong?

Circular dependency between tests and EELS.

How was it fixed?

Splitting out the RLP code into its own library.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@SamWilsn SamWilsn force-pushed the ethereum-rlp branch 2 times, most recently from d9255a4 to 534ee74 Compare November 13, 2024 15:33
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.64259% with 199 lines in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (da1e112) to head (0ffff6c).
Report is 57 commits behind head on master.

Files with missing lines Patch % Lines
src/ethereum/arrow_glacier/transactions.py 21.15% 41 Missing ⚠️
src/ethereum/gray_glacier/transactions.py 21.15% 41 Missing ⚠️
src/ethereum/muir_glacier/transactions.py 26.31% 28 Missing ⚠️
src/ethereum/dao_fork/transactions.py 27.27% 24 Missing ⚠️
src/ethereum/paris/transactions.py 82.69% 9 Missing ⚠️
src/ethereum/arrow_glacier/fork.py 33.33% 4 Missing ⚠️
src/ethereum/byzantium/transactions.py 89.47% 4 Missing ⚠️
src/ethereum/constantinople/transactions.py 89.47% 4 Missing ⚠️
src/ethereum/dao_fork/fork.py 33.33% 4 Missing ⚠️
src/ethereum/frontier/transactions.py 86.66% 4 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   83.59%   83.56%   -0.04%     
==========================================
  Files         644      649       +5     
  Lines       36123    35976     -147     
==========================================
- Hits        30198    30063     -135     
+ Misses       5925     5913      -12     
Flag Coverage Δ
unittests 83.56% <75.64%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants