-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pending-opcodes.md (DATA*, RETURNDATALOAD, EXCHANGE) #868
Conversation
Please update also |
Also add EXCHANGE and RETURNDATALOAD. |
Done & done, please double check |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
=======================================
Coverage 74.11% 74.11%
=======================================
Files 572 572
Lines 32411 32411
=======================================
Hits 24022 24022
Misses 8389 8389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| 0xEF | - | Reserved for EOF compatibility | TBD - [mega EOF](https://notes.ethereum.org/@ipsilon/mega-eof-specification) | | ||
| 0xE8 | EXCHANGE | Deep swap | [EIP-663](https://eips.ethereum.org/EIPS/eip-663) | | ||
| 0xEC | CREATE3 | Create from EOF contained initcode | [EIP-7620](https://eips.ethereum.org/EIPS/eip-7620) | | ||
| 0xED | CREATE4 | Create from transaction contained initcode | [EIP-7620](https://eips.ethereum.org/EIPS/eip-7620) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 0xED | CREATE4 | Create from transaction contained initcode | [EIP-7620](https://eips.ethereum.org/EIPS/eip-7620) | | |
| 0xED | TXCREATE | Create from transaction contained initcode | [EIP-7620](https://eips.ethereum.org/EIPS/eip-7620) | |
Maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to bloat and delay this one. There's going to be yet another update soon (EXT*CALLs), but I want to wait a few days until dust settles and the new names are stable in the EIPs.
But thanks for spotting 👍
What was wrong?
Related to Issue ipsilon/eof#43. Two opcodes proposed for EOF are in conflict (EXCHANGE and DATALOAD)
Also, EXCHANGE and RETURNDATALOAD proposed by Mega-EOF spec and their respective EIPs were missing, so adding them in as well.
Various EOF-related opcodes were out-of-date in the
proposed-opcodes.md
.How was it fixed?
Conflict resolved by moving all DATA* opcodes to the currently empty D section (ipsilon/eof#46).
EXCHANGE and RETURNDATALOAD added,
proposed-opcodes.md
updated to matchpending-opcodes.md