Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pending-opcodes.md (DATA*, RETURNDATALOAD, EXCHANGE) #868

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Jan 24, 2024

What was wrong?

Related to Issue ipsilon/eof#43. Two opcodes proposed for EOF are in conflict (EXCHANGE and DATALOAD)

Also, EXCHANGE and RETURNDATALOAD proposed by Mega-EOF spec and their respective EIPs were missing, so adding them in as well.

Various EOF-related opcodes were out-of-date in the proposed-opcodes.md.

How was it fixed?

Conflict resolved by moving all DATA* opcodes to the currently empty D section (ipsilon/eof#46).

EXCHANGE and RETURNDATALOAD added,

proposed-opcodes.md updated to match pending-opcodes.md

@gumb0
Copy link
Member

gumb0 commented Jan 25, 2024

Please update also proposed-opcodes.md

@gumb0
Copy link
Member

gumb0 commented Jan 25, 2024

Also add EXCHANGE and RETURNDATALOAD.

@pdobacz pdobacz changed the title Update pending-opcodes.md (DATA*) Update pending-opcodes.md (DATA*, RETURNDATALOAD, EXCHANGE) Jan 29, 2024
@pdobacz
Copy link
Contributor Author

pdobacz commented Jan 29, 2024

@gumb0

Please update also proposed-opcodes.md

Also add EXCHANGE and RETURNDATALOAD.

Done & done, please double check

lists/evm/pending-opcodes.md Outdated Show resolved Hide resolved
lists/evm/pending-opcodes.md Outdated Show resolved Hide resolved
lists/evm/proposed-opcodes.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (559ba54) 74.11% compared to head (702845e) 74.11%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #868   +/-   ##
=======================================
  Coverage   74.11%   74.11%           
=======================================
  Files         572      572           
  Lines       32411    32411           
=======================================
  Hits        24022    24022           
  Misses       8389     8389           
Flag Coverage Δ
unittests 74.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

| 0xEF | - | Reserved for EOF compatibility | TBD - [mega EOF](https://notes.ethereum.org/@ipsilon/mega-eof-specification) |
| 0xE8 | EXCHANGE | Deep swap | [EIP-663](https://eips.ethereum.org/EIPS/eip-663) |
| 0xEC | CREATE3 | Create from EOF contained initcode | [EIP-7620](https://eips.ethereum.org/EIPS/eip-7620) |
| 0xED | CREATE4 | Create from transaction contained initcode | [EIP-7620](https://eips.ethereum.org/EIPS/eip-7620) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 0xED | CREATE4 | Create from transaction contained initcode | [EIP-7620](https://eips.ethereum.org/EIPS/eip-7620) |
| 0xED | TXCREATE | Create from transaction contained initcode | [EIP-7620](https://eips.ethereum.org/EIPS/eip-7620) |

Maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to bloat and delay this one. There's going to be yet another update soon (EXT*CALLs), but I want to wait a few days until dust settles and the new names are stable in the EIPs.

But thanks for spotting 👍

@SamWilsn SamWilsn merged commit 119208c into ethereum:master Mar 8, 2024
4 checks passed
@pdobacz pdobacz deleted the patch-1 branch March 8, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants