Refactor make receipt control flow #882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Incl EIPs
Signed-off-by: Tim Beiko <[email protected]>
Co-authored-by: g11tech <[email protected]>
Co-authored-by: g11tech <[email protected]>
Add testnet fork times
Update doc build to use docc
Update pyproject.toml
Update gh-pages.yaml
Start a docc plugin for diffs
Fix build inside of tox
Get diff working
Use ins/del instead of div
Reduce irrelevant diffs in name nodes
Pass through parent instead of creating div
Support markdown diff
pull in latest fladrif
Group diffs where possible
Show diffs in directory listings
Exclude ethereum_{optimized,spec_tools}
Switch to published docc
For some reason, pypy (and cpython on GitHub) cannot seem to correctly patch the london hardfork using the `patch` function. I've switched to using the `patch.object` function since you can explicitly provide the object, bypassing the import error. I'm not 100% sure this is correct.
Update README.md
|
@richardgreg This needs to eventually be merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
In
fork.py'smake_receipt, multipleif/returnblocks are followed by anelseRelated to Issue #
#874
How was it fixed?
Simple refactoring. Use
if/elif/elseflowCute Animal Picture