Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gas_fee to max_gas_fee #886

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

gurukamath
Copy link
Collaborator

What was wrong?

Post London, the gas_fee calculated in fork.py in in fact the max gas that can be paid in the transaction. The variable is renamed accordingly.

Related to Issue #877

How was it fixed?

Renamed the relevant variable.

Cute Animal Picture

iceland-1979445_640

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9ca885c) 74.12% compared to head (30695b3) 74.12%.

Files Patch % Lines
src/ethereum/arrow_glacier/fork.py 0.00% 3 Missing ⚠️
src/ethereum/gray_glacier/fork.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #886   +/-   ##
=======================================
  Coverage   74.12%   74.12%           
=======================================
  Files         572      572           
  Lines       32419    32419           
=======================================
  Hits        24030    24030           
  Misses       8389     8389           
Flag Coverage Δ
unittests 74.12% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamWilsn SamWilsn merged commit 3090f8c into ethereum:master Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants