Evm daemon #891
Merged
Evm daemon #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting the interpreter repeatedly probably takes a ton of time. By starting a single process and reusing it, tests should be faster, especially with JIT.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## forks/cancun #891 +/- ##
================================================
- Coverage 69.96% 69.64% -0.32%
================================================
Files 610 611 +1
Lines 34295 34898 +603
================================================
+ Hits 23993 24306 +313
- Misses 10302 10592 +290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SamWilsn
commented
Mar 1, 2024
| blob_gas_used += self._module( | ||
| "vm.gas" | ||
| ).calculate_total_blob_gas(tx) | ||
| ensure( |
There was a problem hiding this comment.
By @gurukamath in #889:
Based on the EIP, this check has to happen once outside the for loop, after all the transactions have been processed. But tbh, this makes more sense imo unless I am missing something.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.