Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Transaction nonce to U64 #995

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

richardgreg
Copy link
Contributor

What was wrong?

Related to Issue
Fixes #986

How was it fixed?

Simply changed U256 values to U64 in relevant sections

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@richardgreg richardgreg marked this pull request as ready for review August 29, 2024 18:38
richardgreg and others added 2 commits February 12, 2025 11:20
Change Paris' transaction nonce to U64

Change Berlin's transaction nonce to U64

Change London's transaction nonce to U64

Change Dao Fork's transaction nonce to U64

Change Spurious Dragon's transaction nonce to U64

Change Shanghai's transaction nonce to U64

Constantinopole's transaction nonce to U64

Change Tangerine Whistle's transaction nonce to U64

Change Frontier's transaction nonce to U64

Change Instanbul's transaction nonce to U64

Change Byzantium's transaction nonce to U64

Change Homestead's transaction nonce to U64

Change Arrow Glacier's transaction nonce to U64

Change Gray Glacier's transaction nonce to U64

Change Muir Glacier's transaction nonce to U64
@SamWilsn SamWilsn force-pushed the change-transaction-nonce branch from 7b43037 to 6ec3749 Compare February 12, 2025 16:32
@SamWilsn SamWilsn added this to the Post-Prague Re-factoring milestone Feb 12, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (da1e112) to head (feb189c).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
src/ethereum/arrow_glacier/transactions.py 75.00% 1 Missing ⚠️
src/ethereum/dao_fork/transactions.py 50.00% 1 Missing ⚠️
src/ethereum/gray_glacier/transactions.py 75.00% 1 Missing ⚠️
src/ethereum/muir_glacier/transactions.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #995      +/-   ##
==========================================
+ Coverage   83.59%   84.87%   +1.27%     
==========================================
  Files         644      649       +5     
  Lines       36123    36122       -1     
==========================================
+ Hits        30198    30659     +461     
+ Misses       5925     5463     -462     
Flag Coverage Δ
unittests 84.87% <91.30%> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction's nonce should be of type U64
3 participants