Add initial FOCIL implementation #30914
Conversation
jihoonsong
requested review from
MariusVanDerWijden,
holiman,
fjl,
rjl493456442,
lightclient and
jwasinger
as code owners
jihoonsong
force-pushed
the
focil
branch
3 times, most recently
from
33efbee to
78f8ad9
Compare
jihoonsong
force-pushed
the
focil
branch
2 times, most recently
from
9f5db6f to
bbdaa45
Compare
There was a problem hiding this comment.
Pointing out Engine API has incorrect type for inclusion list. Current implementation expects base64 strings whereas the convention and the specs demand hex strings.
I suggest either define inclusion list type and its marshal type in beacon/engine/types.go and let gencodec handles the conversion similar to how ExecutableData is handled. Or manually marshal/unmarshal like how convertRequests handles incoming executionRequests in NewPayloadV4
|
I've addressed comments. Thank you very much for spotting out the issue and suggesting solutions! @ensi321 |
| @@ -350,6 +351,48 @@ type ExecutionPayloadBody struct { | |||
| Withdrawals []*types.Withdrawal `json:"withdrawals"` | |||
| } | |||
|
|
|||
| // Max size of inclusion list in bytes. | |||
| const MaxBytesPerInclusionList = uint64(8192) | |||
There was a problem hiding this comment.
Is this something which will be possibly changed in future?
There was a problem hiding this comment.
It can be changed but not prone to be changed I would say.
jihoonsong
force-pushed
the
focil
branch
2 times, most recently
from
9e1f361 to
29b805d
Compare
This PR implements initial FOCIL specifications. For more information, please refer to EIP-7805 and this PR.