Skip to content

code quality improvements #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

0x0Glitch
Copy link

This PR includes three improvements :

  1. Fix error handling in tar writer during Docker builds - Previously, errors from Flush() and Close() operations on the tar writer in archiveFS were ignored, potentially leading to corrupted Docker builds. Now these errors are properly handled and propagated to the caller.

  2. Add timestamps to client log filenames - Client logs now include UTC timestamps in their filenames, making it easier to track logs chronologically and preventing potential log file collisions when containers are restarted.(as written in TODO)

  3. Remove unused MAC field from ContainerInfo struct - The MAC field was marked with a TODO for removal and wasn't used anywhere in the codebase except for assignments.

@0x0Glitch
Copy link
Author

0x0Glitch commented Apr 25, 2025

Hello @KolbyML,Please have a look at these changes if they make sense.

@KolbyML
Copy link
Member

KolbyML commented Apr 25, 2025

Hello @KolbyML,Please have a look at these changes if they make sense.

Hi @0x0Glitch I already responded to your message on Telegram. I don't maintain this code so I can't review your PR as I said before.

@0x0Glitch
Copy link
Author

Hello @fjl ,Please have a look at these changes if they make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants