code quality improvements #1276
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three improvements :
Fix error handling in tar writer during Docker builds - Previously, errors from
Flush()
andClose()
operations on the tar writer inarchiveFS
were ignored, potentially leading to corrupted Docker builds. Now these errors are properly handled and propagated to the caller.Add timestamps to client log filenames - Client logs now include UTC timestamps in their filenames, making it easier to track logs chronologically and preventing potential log file collisions when containers are restarted.(as written in TODO)
Remove unused MAC field from ContainerInfo struct - The
MAC
field was marked with a TODO for removal and wasn't used anywhere in the codebase except for assignments.