Skip to content
This repository has been archived by the owner on Jun 13, 2023. It is now read-only.

support configurable settings #475

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

hackmod
Copy link
Contributor

@hackmod hackmod commented Apr 27, 2018

WARNING

[WIP] Please do not merge it

support configurable settings using meteor --settings like as meteor --settings local.json or meteor-build-client blahblah -s settings.json

Done

  • fixed i18n messages to use Settings like as it's ticker name etc.
  • genesis hashes for well known ethereum networks added (callistio, ubiq, ellasim, music, expanse)
  • use publicSettings global variable like as the Settings in the mist already does at the modules/settings.js
    • the mist use local config.json to setup some variables like as {"production":true,"mode":"mist"}. it can be extended easily.

ToDo

  • proofread translation messages

example

this is a sample case for the Callisto Network.

{
    "public": {
        "title": "Callisto Network",
        "unit": "CLO",
        "ether": "CLO",
        "Ether": "CLO",
        "ethereum": "callisto",
        "Ethereum": "Callisto",
        "walletName": "CLO Wallet",
        "walletDescription": "The CLO Wallet",
        "walletKeywords": "wallet, dapp, CLO, callisto",
        "downloadUrl": "https://github.com/EthereumCommonwealth/mist/releases",
        "blockExplorerUrl": "https://cloexplorer.net",
        "blockExplorerAddrUrl": "https://cloexplorer/addr/",
        "geth": "geth",
        "gethIpc": "geth.ipc",
        "gethConnectionUrl": "ws://localhost:8546"
    }
}

further more, multi configurations also possible.

{
    "public": {
        "networks": {
            "ethersocial": {
                "title": "EtherSocial Network",
                "noUsePrice": false,
                "ticker": "ETH",
                "unit": "ESN",
                "ether": "esn",
                "Ether": "ESN",
                "ethereum": "ethersocial",
                "Ethereum": "Ethersocial",
                "walletName": "ESN Wallet",
                "walletDescription": "The ESN Wallet",
                "walletKeywords": "wallet, dapp, ESN, ethersocial",
                "downloadUrl": "https://github.com/ethersocial/mist/releases",
                "blockExplorerUrl": "https://ethersocial.net",
                "blockExplorerAddrUrl": "https://ethersocial.net/addr/",
                "geth": "gesn",
                "gethIpc": "gesn.ipc",
...

@hackmod hackmod force-pushed the configurable-settings branch 3 times, most recently from 190539f to 9d48650 Compare May 1, 2018 22:58
@hackmod hackmod changed the base branch from develop to web3.js-1.0.0 May 1, 2018 22:59
@hackmod hackmod force-pushed the configurable-settings branch from 9d48650 to cf6e875 Compare May 1, 2018 23:30
@hackmod
Copy link
Contributor Author

hackmod commented May 1, 2018

@evertonfraga
Copy link
Member

Hi @hackmod, thanks for the contribution.

This is something we have to consider. How do you use Geth in Callisto network? Does the network aims to comprise Dapps as well (full mist browser) or wallet only?

@hackmod
Copy link
Contributor Author

hackmod commented May 29, 2018

How do you use Geth in Callisto network?

Callisto support their modified clients, both parity based and geth based client (go-callisto).
basically, Callisto is a go-ethereum based off ethereum chain, aim on Dapp ecosystem.

@evertonfraga
Copy link
Member

So it's not just a matter of changing the network ID to account for Callisto network, it requires binary management. Did you fork and modified Mist as well?

@hackmod
Copy link
Contributor Author

hackmod commented Jun 1, 2018

So it's not just a matter of changing the network ID to account for Callisto network, it requires binary management. Did you fork and modified Mist as well?

basically yes.
Other mist+meteor-dapp-wallet based off wallet change their clientBinaries.json like as https://github.com/ethersocial/mist/blob/develop/clientBinaries.json and change ether unit like as
Ethersocial/mist@4c834f9#diff-0158e844f76fdda3e7e216d93e8b1b4fR30

but as you can see, it is almost trivial change, I think.

@hackmod hackmod force-pushed the configurable-settings branch 2 times, most recently from 2241506 to 28384ce Compare June 7, 2018 14:07
@hackmod hackmod changed the base branch from web3.js-1.0.0 to master June 7, 2018 14:08
@hackmod
Copy link
Contributor Author

hackmod commented Jun 7, 2018

rebased onto master

@hackmod hackmod force-pushed the configurable-settings branch from 28384ce to 9db23f3 Compare June 14, 2018 19:14
@hackmod
Copy link
Contributor Author

hackmod commented Jun 15, 2018

updated / rebased

  • rename walletConfig => Settings => publicSettings (now)

@evertonfraga
Copy link
Member

Alright, great. we're at capacity dealing with the next mist release (already in master branch, if you want to test).

After that I'll come back to this PR and assess it. Thanks for the contribution :)

@Adyfamba
Copy link

Adyfamba commented May 7, 2019

Hello..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants