WIP: make sure validate_header also validates seal on parent #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
In CliqueConsensus we can not validate a seal on a header if we haven't validated the seal of the parent. But that's exactly what can happen when using
validate_header. This was causing a bug during Görli sync that I just had ignored so far.How was it fixed?
THE IMPLEMENTATION IS JUST AN EXAMPLE
We probably want to fix that on the Clique level to not waste cpu cycles when it's not needed.
I'm going to wait until the dust around #1874 / #1875 has settled before I attempt to send a proper fix.
To-Do
Cute Animal Picture